Merged
Conversation
MRiganSUSX
requested changes
Feb 10, 2026
Contributor
MRiganSUSX
left a comment
MRiganSUSX
left a comment
There was a problem hiding this comment.
Thanks @mroda88.
I have some comments.
| The name of the measurement, a.k.a. the content of the `FROM` part of the query is the name of the protobuf message, including it's namespace, which is defined in the `package` line of the protobuf. | ||
|
|
||
| Example: | ||
| [DataWriterInfo](https://github.com/DUNE-DAQ/dfmodules/blob/52ec3406ad8957cc4d921844cb68e3729e03b1ac/schema/dfmodules/opmon/DataWriter.proto#L5) objects are turned into `dunedaq.dfmodules.opmon.DataWriterInfo` measurements. |
Contributor
Author
There was a problem hiding this comment.
I cannot reproduce this.
| The name of the measurement, a.k.a. the content of the `FROM` part of the query is the name of the protobuf message, including it's namespace, which is defined in the `package` line of the protobuf. | ||
|
|
||
| Example: | ||
| [DataWriterInfo](https://github.com/DUNE-DAQ/dfmodules/blob/52ec3406ad8957cc4d921844cb68e3729e03b1ac/schema/dfmodules/opmon/DataWriter.proto#L5) objects are turned into `dunedaq.dfmodules.opmon.DataWriterInfo` measurements. |
Contributor
There was a problem hiding this comment.
And again, I would much prefer explicitly showing the example here than linking to pieces of code that are dynamic and subject to change.
Contributor
Author
There was a problem hiding this comment.
These links are permanent
MRiganSUSX
approved these changes
Feb 13, 2026
Contributor
MRiganSUSX
left a comment
MRiganSUSX
left a comment
There was a problem hiding this comment.
Thanks for the improvements.
I think there is a lot more that could be included, but if you don't want to clutter it, I agree this is already much better than the previous version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.