Skip to content

Conversation

@eflumerf
Copy link
Member

@eflumerf eflumerf commented Jan 14, 2026

Update configuration paradigm for IPM, pass structs with configuration information to connect_for_sends and connect_for_receives.

Add connection_name parameter to configuration, use this when logging so that it is clear which connection is having particular issues.

Description

Resolves #112

This PR replaces the JSON configuration of ipm (in connect_for_receives and connect_for_sends) with configuration structs defined in Receiver and Sender. This removes the JSON dependency from ipm.

Type of change

  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)

Note that this change needs to be tested together with DUNE-DAQ/iomanager#127.

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

information to connect_for_sends and connect_for_receives.

Add connection_name parameter to configuration, use this when logging so
that it is clear which connection is having particular issues.
Copy link
Contributor

@bieryAtFnal bieryAtFnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified that these changes do not affect existing functionality by successfully running a selection of regresssion tests.

Copy link
Contributor

@ron003 ron003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked fairly thoroughly and all seems well.

@ron003 ron003 merged commit cbaa72f into develop Jan 26, 2026
3 checks passed
@ron003 ron003 deleted the eflumerf/ConnectionNameToIPM branch January 26, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to send within timeout message unhelpful

4 participants