Temp fs dsim mapping update #172
Conversation
Updated channel mapping: matches https://docs.google.com/spreadsheets/d/1YnXpoeFB6laCJ_2x0_RqJg6IHxhZB9kz6KCtvWv5f9Q/edit?gid=1754157014#gid=1754157014, assumes larndsim channel mapping follows https://docs.google.com/spreadsheets/d/1G4LgfH1r7tTLs5DAgaJuRqW1nV-9XD-EU-Tr_UWgW4g/edit?gid=0#gid=0
fixed formatting
Load geometry in the first stage for FSD
|
With Alex's fix for loading/skipping the dead channels map everything is working as far as I can tell on my end. Did any of the validation mentioned above happen? I can also provide the cosmic sim flow file I managed to produce using the this branch. |
|
If you send me the location of the file, I can do a quick validation! Jan might have validated the branch already, but I haven't heard anything. |
|
FSD cosmic sim flow file with the new light noise spectra can be found here (also sent in a Slack message): |
Remove the waveform deconvolution step for now as the FSD specific inputs are not available. Fix a typo in the channel map in `LightEventGeneratorMC.yaml` Change a few remaining 2x2 values to FSD values (e.g. nchantpc)
|
I'm trying to get everything organized for the FSD production with light and would like to finish merging this in to develop. I produced several flow files with the light simulation both from this branch and with a test merge into develop and nothing seems obviously wrong looking at a few entries in the hdf5 files. Are there any further checks we want to do now, or merge this and do it as part of an initial validation of the FSD production (where I produce ~30 or so files). Current files available here: |
|
Looks good to me. But I see there are still merge conflicts? |
Yeah, those are from Noe and me editing the same yamls. I'll fix them as part of the merge / closing the PR. I already tested the changes in a local pull as part of producing a couple files. |
|
Looks good to me too. It looks like some of these yaml files are used for processing both MC and data. One more quick check would be to verify that these changes run of data files as expected. |
|
@cuddandr are you still planning on resolving the conflicts and merging in? |
Updating Jan's land-sim to ndlar-flow channel