Skip to content

Feature/adc clip tag #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jvmead wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Feature/adc clip tag #217

jvmead wants to merge 27 commits into from

Conversation

@jvmead
Copy link
Member

@jvmead jvmead commented Nov 4, 2025

added 'clipped' info to sipm level waveforms

jvmead and others added 27 commits September 30, 2025 02:34
@jvmead
baseline fix (abs on np.ptp output and zero mask
3112f3c
@jvmead
feeding RMS from wvfm filter (baseline function) stage through to sum…
34422e1 
…ming of waveforms and hit finder thresholds to replace MAD mask method
@jvmead
ongoing bug fixing for passing rms forward to hitfinder
6e2874a
@jvmead
changing settings so that inputs are compatabile with 600 tick wvfms
5689218
@jvmead
removing default values so yaml has to specify
70477b7
@jvmead
narrower segment width to avoid signal in wvfms without padding (may …
04524a0 
…increase spread in baseline but small compared to potential bias from signal)
@jvmead
removing factor 4 from fwvfm and adding clipped to wvfm/data/
ae54255
@jvmead
work in progress - still doesn't sync up with expectation
722e63b
@jvmead
trying to fix clipped tag unsucessfully
12a5706
@jvmead
running now, need to sanity check
09811b0
@jvmead
sanity check looks good now
9305893
@jvmead
inherited for summed wvfms
11a4d28
@jvmead
pushing last changes
af1426e
@mjkramer @jvmead
Fix NaN baselines
46a57c7
@jvmead
fix for the fix
2460c87
@jvmead
removing derivative and option to not just use local maxima
ccb9929
@jvmead
Merge remote-tracking branch 'upstream/develop' into feature/baseline…
e526cd9 
…_fix_rms_thresholding
@jvmead
Merge branch 'removing_derivative_option' into feature/baseline_fix_r…
3126fd0 
…ms_thresholding
@jvmead
resolving conflicts
53d6bbc
@jvmead
fix the args
10718c4
@jvmead
revert back to cherry picked version
8dde15a
@jvmead
fprompt testing avoiding edge cases or filling with nan
d35d3cb
@jvmead
playing with logic of masking
d75456d
@jvmead
fixes from mathilde for running on run2 data
7c39c1e
@jvmead
Merge branch 'develop' into feature/adc_clip_tag
97726bd
@jvmead
tidyup before test
1686a0f
@jvmead
fixing rogue line in wvmf sum
287f9f4
@sam-fogarty
Copy link
Member

sam-fogarty commented Nov 25, 2025

Could we get this merged into develop soon? It would be useful for radon data processing. I think it may need an extra set of eyes before merging. @krwood @mjkramer I'll see if I can do some checks myself.

@jvmead jvmead mentioned this pull request Dec 8, 2025
Open
@mjkramer
Copy link
Member

mjkramer commented Jan 10, 2026

I'm testing this plus #229 on some of the Run 2 data. Pushed a few minor changes to the matt-staging branch. If the output looks good, then I think we can merge this and #229 and close the others (which all got absorbed into #229 if I'm not mistaken).

@jvmead
Copy link
Member Author

jvmead commented Jan 11, 2026

great! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvmead @sam-fogarty @mjkramer