Skip to content

Make the plugin compatible with recent Sketch updates #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make the plugin compatible with recent Sketch updates #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cc7ae0
Replace absoluteRect() with frame() which returns the exact same valu…
rodionovd Oct 9, 2023
477ede5
Fix sketchVersionNumber() to support integral version numbers (e.g. 9…
rodionovd Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions PDF Export.sketchplugin/Contents/Sketch/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ function exportArtboards(artboards, outputName) {
newExportFormat.name = ''
newExportFormat.format = 'png'

var rect = artboard.absoluteRect().rect()
var rect = artboard.frame().rect()


if (sketchVersionNumber() < 790) {
Expand Down Expand Up @@ -299,14 +299,16 @@ function alertNoArtboards(message) {


// Return the version number for sketch — turned into a single integer
// e.g. '3.8.5' => 385, '40.2' => 402
// e.g. '3.8.5' => 385, '40.2' => 402, '100' => 1000, '101.2' => 1012
function sketchVersionNumber() {
var version = NSBundle.mainBundle().objectForInfoDictionaryKey("CFBundleShortVersionString")
var versionNumber = version.stringByReplacingOccurrencesOfString_withString(".", "") + ""
while (versionNumber.length != 3) {
versionNumber += "0"
if (versionNumber.length === version.length()) {
// Account for version numbers without a decimal part (e.g. '99', '100', etc)
return 10 * parseInt(versionNumber)
} else {
return parseInt(versionNumber)
}
return parseInt(versionNumber)
}

// Return a JSON object from a file path
Expand Down