Add trap_GetPings, so that engine does not mutate playerstate #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have sgame retrieve pings by using a syscall, instead of the engine writing the ping into shared memory.
This is an attempt to simplify the interface between the engine and the VM, which could benefit future sandboxing technology migrations. The player state portion of the shared memory will now be readonly for the engine, rather than a two-way communication channel. Hopefully I can do the same for the entity state next, so that all of the shared memory is read-only for the engine.
Companion: Unvanquished/Unvanquished#3207