Don't set -pie flag with AppleClang #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently it doesn't do anything, and triggers a warning about an unused command line argument. When USE_HARDENING is enabled, this warning breaks a bunch of other try_compile's, causing flags to be rejected that should have been accepted.
This is the default since Mac OS 10.9 and we don't support any versions older than that. In newer versions of Clang, it causes warning spam about an unused flag so remove it.
Member
Author
|
Added another commit removing another flag which causes unused argument warning spam ( |
Member
|
It works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently it doesn't do anything, and triggers a warning about an unused command line argument. When USE_HARDENING is enabled, this warning breaks a bunch of other try_compile's, causing flags to be rejected that should have been accepted.