Migrate in_ cvars
#1839
Merged
Migrate in_ cvars
#1839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to avoid a printf from SDL.
The Debug level replaces the in_gameControllerDebug cvar. Other game controller-related messages are on Verbose through Warn levels.
Also mark it latched and don't modify the value if it is out of range.
Fixes DaemonEngine#983. Written with the help of https://github.com/slipher/source-tools/blob/master/cvar_migrate.py.
illwieckz
approved these changes
Oct 3, 2025
Member
illwieckz
left a comment
illwieckz
left a comment
There was a problem hiding this comment.
Also add a controllerLog configurable with client.controller.*.
LGTM.
Member
Author
Only that one? |
Member
|
LGTM for the whole, I just mentionned something that wasn't in the PR message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve game controller logging and fix a 'gamepad leaked' message from SDL.