Skip to content

Conversation

@slipher
Copy link
Member

@slipher slipher commented Oct 4, 2025

No description provided.

To match the prefix of other cvars which affect exclusively
joysticks, not gamepads.
Also make sure it always really matches the state of whether gamepad
mode is being used.
Not tested as I don't have a joystick handy, but I assume whatever
20-year-old quirk necessitating that is no longer present in SDL3.
Using migration helper script.
@illwieckz
Copy link
Member

illwieckz commented Oct 8, 2025

I discover w have j_ cvars and it's a pretty bad name!

If we are to renaming them (and it's not a big problem since joysticks aren't use yet), instead of just doing j_forward_axis to j_forwardAxis we may jump in the dotted namespace bandwagon once for all. Something like joystick.* or we may even go the input.joystick.* way and pave the way for similar naming for other devices (mouse, keyboard…) in the future.

@slipher
Copy link
Member Author

slipher commented Oct 8, 2025

During the cvar migration, I have mostly avoided renaming cvars, to avoid changing interfaces and avoid opening cans of bike-shedding worms. Deviating from that was a mistake! I have now removed the commit Rename joystick cvars of pattern j_foo_axis to j_fooAxis.

@illwieckz
Copy link
Member

Yes we better do dedicated PRs for renaming. I don't really see the benefit of introducing a name change if it's not well thought as an interface redesign may requires it to be.

Copy link
Member

@illwieckz illwieckz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slipher slipher merged commit fae6ddd into DaemonEngine:master Oct 8, 2025
9 checks passed
@slipher slipher deleted the j_migration branch October 8, 2025 07:40
@VReaperV
Copy link
Contributor

VReaperV commented Oct 8, 2025

I discover w have j_ cvars and it's a pretty bad name!

If we are to renaming them (and it's not a big problem since joysticks aren't use yet), instead of just doing j_forward_axis to j_forwardAxis we may jump in the dotted namespace bandwagon once for all. Something like joystick.* or we may even go the input.joystick.* way and pave the way for similar naming for other devices (mouse, keyboard…) in the future.

I dislike these dotted namespace for they make it annoying to autocomplete with tab. Also, most cvars don't do that.

@VReaperV
Copy link
Contributor

VReaperV commented Oct 8, 2025

Something like joystick.* or we may even go the input.joystick.* way and pave the way for similar naming for other devices (mouse, keyboard…) in the future.

That's even worse, longer cvar names/more typing for no reason.

@slipher
Copy link
Member Author

slipher commented Oct 8, 2025

Ref #1236 for cvar namespace wars 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants