-
Notifications
You must be signed in to change notification settings - Fork 69
Migrate remaining joystick-related cvars #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To match the prefix of other cvars which affect exclusively joysticks, not gamepads.
Also make sure it always really matches the state of whether gamepad mode is being used.
Not tested as I don't have a joystick handy, but I assume whatever 20-year-old quirk necessitating that is no longer present in SDL3.
Using migration helper script.
|
I discover w have If we are to renaming them (and it's not a big problem since joysticks aren't use yet), instead of just doing |
|
During the cvar migration, I have mostly avoided renaming cvars, to avoid changing interfaces and avoid opening cans of bike-shedding worms. Deviating from that was a mistake! I have now removed the commit |
|
Yes we better do dedicated PRs for renaming. I don't really see the benefit of introducing a name change if it's not well thought as an interface redesign may requires it to be. |
illwieckz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I dislike these dotted namespace for they make it annoying to autocomplete with tab. Also, most cvars don't do that. |
That's even worse, longer cvar names/more typing for no reason. |
|
Ref #1236 for cvar namespace wars 😛 |
No description provided.