rebate fixes and logging for photo #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses fixes in the rebate logic and improves logging for photo display along with minor code cleanups. Key changes include removal of deprecated/commented code, refinements in queryset filtering (adding case insensitivity) and ordering, and an update to the rebate minimum days condition.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| home/views.py | Removed commented-out code, added ordering in Period query, adjusted rebate_days condition, and improved logging in profile view. |
| home/utils/rebate_checker.py | Updated email filtering to be case-insensitive; however, a typo in the LongRebate queryset is present. |
| home/utils/month.py | Refined Student queryset to use case-insensitive filtering and improved date calculation. |
| home/models/home.py | Removed unused/commented-out code related to photographs. |
| home/admin.py | Cleaned up commented code in the admin configuration. |
| home/adapters/account_adapter.py | Removed deprecated comments in the email validation logic. |
Comments suppressed due to low confidence (1)
home/views.py:202
- Verify that removing the '0 <' check in the rebate_days condition is intentional, as this change may flag zero or negative values as insufficient rebate days.
elif rebate_days < 2:
purav10
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.