Open
Conversation
added 12 commits
April 18, 2019 17:08
GregoryWilusz
commented
Apr 28, 2019
| 'id' => building_id.to_s, | ||
| 'attributes' => { | ||
| 'name' => 'Building_1', | ||
| 'siege_ability' => nil |
Author
There was a problem hiding this comment.
Testując ten endpoint jednostkowo, musiałem zmienić wartość na nil. Przeliczenie wykonuje się dopiero w migracji.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Przeliczenie siege_ability wykonałem w oddzielnej migracji. Jak można zrobić to lepiej, tj. aby po każdej akcji dodania Budynku lub zmianie liczby Warriors przypisanych do tego budynku następowało przeliczenie siege_ability?
Podczas pisania testów natknąłem się na dziwną rzecz. Dodając do Serializera (a wcześniej do pole do tabeli) atrybut siege_ability (z "podłogą"), w response atrybut był z myślnikiem. Musiałem dodać: ActiveModel::Serializer.config.key_transform = :underscore, żeby pozbyć się tego problemu. Dlaczego tak się dzieje?