Skip to content

Conversation

@Neraste
Copy link
Member

@Neraste Neraste commented Mar 1, 2025

Fixes #138.

But I don't like that a variable may contain None, "self" and a pathlibi.Path instance at the same time.

@Neraste Neraste added the bug Something isn't working label Mar 1, 2025
@Neraste Neraste self-assigned this Mar 1, 2025
@Neraste Neraste changed the title Fix None passed as audio file by default Fix None passed as audio file by default Mar 1, 2025
@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (2448487) to head (0f395ff).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #139   +/-   ##
========================================
  Coverage    98.03%   98.03%           
========================================
  Files           16       16           
  Lines         1377     1377           
========================================
  Hits          1350     1350           
  Misses          27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neraste Neraste changed the title Fix None passed as audio file by default Fix "None" passed as audio file by default Mar 1, 2025
@Neraste Neraste merged commit 15a2d3d into develop Mar 1, 2025
16 checks passed
@Neraste Neraste deleted the fix/138-mpv-none branch March 1, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MPV tries to open None

2 participants