Conversation
Serialize the ID of work types to be able to use the
`/api/library/work-types/{id}` route, otherwise the ID has to be guessed.
Found while trying to implement feeding in Japan7/karaberus#38
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #165 +/- ##
========================================
Coverage 98.61% 98.61%
========================================
Files 78 78
Lines 1876 1876
========================================
Hits 1850 1850
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Feed tags/medias/artists/karas to dakara on upload and on startup. Define tag colors (hue) so we can set colors in karaberus and have it change in dakara at the same time. Could be obviously improved by checking locally for changes of karaokes, medias and artists instead of just PUTing everything on sync. Probably not worth it implement that for tags. We can't yet update work types decently because dakara doesn't return their IDs. (DakaraProject/dakara-server#165) This assumes that video files will all be called `{id}.mkv`, so the downloader will have to follow this naming scheme to work with dakara. The files are not all matroska files, but it should not be a problem in practice. #40
Feed tags/medias/artists/karas to dakara on upload and on startup. Define tag colors (hue) so we can set colors in karaberus and have it change in dakara at the same time. Could be obviously improved by checking locally for changes of karaokes, medias and artists instead of just PUTing everything on sync. Probably not worth it implement that for tags. We can't yet update work types decently because dakara doesn't return their IDs. (DakaraProject/dakara-server#165) This assumes that video files will all be called `{id}.mkv`, so the downloader will have to follow this naming scheme to work with dakara. The files are not all matroska files, but it should not be a problem in practice. #40
|
Please update test helper here. |
|
I can't seem to get the tests to pass, |
|
Ah, the helper is also used to assert work type obtained by other serializers (namely, |
|
Ping |
|
Oh my bad.
I think I’d rather add the ID to this serializer too, doesn’t make much sense to leave it out. |
|
Good. |
2 participants
Serialize the ID of work types to be able to use the
/api/library/work-types/{id}route, otherwise the ID has to be guessed.Found while trying to implement feeding in Japan7/karaberus#38