[shinsj4653] Week 03 Solutions#1272
Merged
shinsj4653 merged 8 commits intoDaleStudy:mainfrom Apr 20, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR includes the Week 03 Solutions with implementations and reflective comments for multiple algorithm problems. Key changes include:
- Additional reflective notes (회고) and approach explanations across the solutions.
- New solution files for problems such as valid-palindrome, number-of-1-bits, maximum-subarray, decode-ways, and combination-sum.
- Updated implementations, including both dynamic programming and recursive approaches in decode-ways and combination-sum.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| validate-binary-search-tree/shinsj4653.py | Added a reflective note about passing upper and lower bounds. |
| valid-palindrome/shinsj4653.py | Added a basic structure with explanations for the valid-palindrome problem. |
| number-of-1-bits/shinsj4653.py | Added a problem explanation and structure for the number-of-1-bits solution. |
| maximum-subarray/shinsj4653.py | Implemented the Kadane’s algorithm with reflective notes on the approach. |
| decode-ways/shinsj4653.py | Provided three solution approaches (recursive with memoization and bottom-up DP) with commentary. |
| combination-sum/shinsj4653.py | Offered two implementations (DP-based and recursive) with detailed reflections and notes. |
| if start_idx >= n : | ||
| return | ||
| for i in range(1, 2): | ||
| num = int(s[start_idx:start_idx + i] |
There was a problem hiding this comment.
Missing closing parenthesis in the int conversion. Consider updating the line to 'num = int(s[start_idx:start_idx + i])'.
Suggested change
| num = int(s[start_idx:start_idx + i] | |
| num = int(s[start_idx:start_idx + i]) |
Contributor
|
저를 리뷰어로 할당하신 이유가 있을까요? |
PDKhan
approved these changes
Apr 20, 2025
Contributor
PDKhan
left a comment
There was a problem hiding this comment.
한주에 리뷰를 2번 하게 되지만 일단 요청하셔서 리뷰합니다.
3주차 수고하셨습니다.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!