Skip to content

[sounmind] WEEK 03 solutions#1318

Merged
sounmind merged 2 commits intoDaleStudy:mainfrom
sounmind:main
Apr 22, 2025
Merged

[sounmind] WEEK 03 solutions#1318
sounmind merged 2 commits intoDaleStudy:mainfrom
sounmind:main

Conversation

@sounmind
Copy link
Copy Markdown
Member

@sounmind sounmind commented Apr 18, 2025 •
edited
Loading

๋‹ต์•ˆ ์ œ์ถœ ๋ฌธ์ œ

  • Decode ways
  • Maximum subarray

์ž‘์„ฑ์ž ์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ์šฐ์ธก ๋ฉ”๋‰ด์—์„œ PR์„ Projects์— ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”.
  • Projects์˜ ์˜ค๋ฅธ์ชฝ ๋ฒ„ํŠผ(โ–ผ)์„ ๋ˆŒ๋Ÿฌ ํ™•์žฅํ•œ ๋’ค, Week๋ฅผ ํ˜„์žฌ ์ฃผ์ฐจ๋กœ ์„ค์ •ํ•ด์ฃผ์„ธ์š”.
  • ๋ฌธ์ œ๋ฅผ ๋ชจ๋‘ ํ‘ธ์‹œ๋ฉด ํ”„๋กœ์ ํŠธ์—์„œ Status๋ฅผ In Review๋กœ ์„ค์ •ํ•ด์ฃผ์„ธ์š”.
  • ์ฝ”๋“œ ๊ฒ€ํ† ์ž 1๋ถ„ ์ด์ƒ์œผ๋กœ๋ถ€ํ„ฐ ์Šน์ธ์„ ๋ฐ›์œผ์…จ๋‹ค๋ฉด PR์„ ๋ณ‘ํ•ฉํ•ด์ฃผ์„ธ์š”.

๊ฒ€ํ† ์ž ์ฒดํฌ ๋ฆฌ์ŠคํŠธ

Important

๋ณธ์ธ ๋‹ต์•ˆ ์ œ์ถœ ๋ฟ๋งŒ ์•„๋‹ˆ๋ผ ๋‹ค๋ฅธ ๋ถ„ PR ํ•˜๋‚˜ ์ด์ƒ์„ ๋ฐ˜๋“œ์‹œ ๊ฒ€ํ† ๋ฅผ ํ•ด์ฃผ์…”์•ผ ํ•ฉ๋‹ˆ๋‹ค!

  • ๋ฐ”๋กœ ์ด์ „์— ์˜ฌ๋ผ์˜จ PR์— ๋ณธ์ธ์„ ์ฝ”๋“œ ๋ฆฌ๋ทฐ์–ด๋กœ ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”.
  • ๋ณธ์ธ์ด ๊ฒ€ํ† ํ•ด์•ผํ•˜๋Š” PR์˜ ๋‹ต์•ˆ ์ฝ”๋“œ์— ํ”ผ๋“œ๋ฐฑ์„ ์ฃผ์„ธ์š”.
  • ํ† ์š”์ผ ์ „๊นŒ์ง€ PR์„ ๋ณ‘ํ•ฉํ•  ์ˆ˜ ์žˆ๋„๋ก ์Šน์ธํ•ด์ฃผ์„ธ์š”.

@github-actions github-actions bot added the py label Apr 18, 2025
@sounmind
refactor: improve maxSubArray implementation
1a5966c 
- Enhance code readability with clearer variable names
- Add detailed docstring for function explanation
- Maintain functionality while optimizing structure
@hestia-park hestia-park self-requested a review April 18, 2025 23:00
hestia-park
hestia-park reviewed Apr 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hestia-park hestia-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ณ‘ํ•ฉ์„ ์œ„ํ•ด์„œ ๋งˆ์ง€๋ง‰์ค„์— ๊ฐœํ–‰๋ฌธ์ž ์ถ”๊ฐ€ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค!
decode-ways ์ €๋Š” ๋ชป ํ’€์—ˆ๋Š”๋ฐ ๋•๋ถ„์— ํ’€์ด๋ฒ• ๊ฐ€๋‹ฅ์ด ์žกํžˆ๋„ค์š”. ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

TonyKim9401
TonyKim9401 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@TonyKim9401 TonyKim9401 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3์ฃผ์ฐจ ๋ฌธ์ œ ํ’€์ด ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค.
๋ฌธ์ œ์— ๋Œ€ํ•œ ์ดํ•ด ๋‚ด์šฉ์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์…”์„œ ์ฝ”๋“œ ๋ฆฌ๋ทฐ์— ๋”์šฑ ๋„์›€์ด ๋˜์—ˆ์Šต๋‹ˆ๋‹ค. ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค
๊ฐ ์ค„๋งˆ๋‹ค ๋ถ€์—ฐ ์„ค๋ช…๋„ ์ž์„ธํ•˜๊ฒŒ ์ ์–ด์ฃผ์…จ๋„ค์š”!
4์ฃผ์ฐจ ๋ฌธ์ œ ํ’€์ด๋„ ํŒŒ์ดํŒ…์ž…๋‹ˆ๋‹ค.

@sounmind sounmind merged commit ec26d38 into DaleStudy:main Apr 22, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hestia-park hestia-park hestia-park left review comments

@TonyKim9401 TonyKim9401 TonyKim9401 approved these changes

Assignees

@sounmind sounmind

Labels

py

Projects

No open projects
๋ฆฌํŠธ์ฝ”๋“œ ์Šคํ„ฐ๋”” 4๊ธฐ
Status: Completed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sounmind @TonyKim9401 @hestia-park