[clara-shin] WEEK 05 solutions#1392
Merged
clara-shin merged 7 commits intoDaleStudy:mainfrom May 2, 2025
Merged
Conversation
ayosecu
reviewed
Apr 28, 2025
| // 두 번째 날부터 | ||
| for (let i = 1; i < prices.length; i++) { | ||
| // 현재 가격이 최저 가격보다 낮으면 최저 가격 업데이트 | ||
| if (prices[i] < minPrice) { |
Contributor
There was a problem hiding this comment.
Math.min 함수를 쓰면 직관적이고, 한줄로 코드량도 줄어들것 같아요!
Contributor
Author
There was a problem hiding this comment.
@ayosecu
그러네요! 내장함수를 사용하니 더 간결하고 의도가 명확히 보여요 감사합니다!
ayosecu
reviewed
Apr 28, 2025
| const currentProfit = prices[i] - minPrice; | ||
|
|
||
| // 최대 이익 업데이트 | ||
| if (currentProfit > maxProfit) { |
Contributor
There was a problem hiding this comment.
Math.max 함수를 쓰면 직관적이고, 한줄로 코드량도 줄어들것 같아요!
ayosecu
reviewed
Apr 30, 2025
| const map = new Map(); | ||
|
|
||
| for (let str of strs) { | ||
| const count = new Array(26).fill(0); // 알파벳 개수 초기화 |
Contributor
There was a problem hiding this comment.
alphabet index 를 활용하여 key 값을 만든 부분이 흥미롭습니다.
저는 sort 를 사용해서 Time Complexity 가 O(nklogk) 가 되었는데, 이 방식을 이용하면 O(nk) 로 줄일 수 있겠네요. 👍
ayosecu
approved these changes
May 1, 2025
Contributor
ayosecu
left a comment
ayosecu
left a comment
There was a problem hiding this comment.
변수명이나, 구조가 깔끔해서 가독성이 좋은 코드 같습니다.
이번 한 주도 수고 하셨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!