Skip to content

[mkwkw] WEEK 01 Solutions #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2025
Merged

[mkwkw] WEEK 01 Solutions #1677

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0ef2e2
Contains-duplicate
mkwkw Jul 20, 2025
9e2dbc7
setup: \n
mkwkw Jul 20, 2025
f9870c8
change: map -> set
mkwkw Jul 21, 2025
578de07
two-sum
mkwkw Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions contains-duplicate/mkwkw.java
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

map에 저장해둔 key, value 중 key값 만을 사용하고 계신것 같아서, set을 사용해도 괜찮지 않을까 싶습니다!

Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
//using map
//1. using map
//2. using set : why? It doesn't have to use a pair of key and value.

class Solution {
public boolean containsDuplicate(int[] nums) {
Map<Integer, Boolean> appearance = new HashMap<>();
//Map<Integer, Boolean> appearance = new HashMap<>();
Set<Integer> appearance = new HashSet<>();

for(int i=0; i<nums.length; i++)
{
if(appearance.containsKey(nums[i]))
if(appearance.contains(nums[i]))
{
return true;
}
else
{
appearance.put(nums[i], true);
appearance.add(nums[i]);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set을 활용한 접근 방식은 굉장히 좋은 것 같습니다. 고생하셨습니다!

위 부분에는 Early Return을 적용한다면, 더 가독성이 높아지지 않을까 생각이 들어 참고차 자료 공유드립니다🙏
https://thearchivelog.dev/article/are-early-returns-any-good/


Expand Down