Merged
Conversation
shinheekim
approved these changes
Jul 26, 2025
two-sum/rivkode.py
Outdated
| if complement in dic: | ||
| return [i, dic[complement]] | ||
|
|
||
| dic[v] = i No newline at end of file |
Contributor
There was a problem hiding this comment.
파일의 마지막에 개행문자를 추가해서 Posix 표준 준수해주시면 좋을 거 같습니다.
top-k-frequent-elements/rivkode.py
Outdated
Comment on lines
+20
to
+26
| for v in nums: | ||
| if v in dic: | ||
| cur = dic[v] | ||
| cur += 1 | ||
| dic[v] = cur | ||
| else: | ||
| hash[num] = 1 | ||
| dic[v] = 1 |
Contributor
There was a problem hiding this comment.
for v in nums:
dic[v] = dic.get(v, 0) + 1이런 식으로 간결하기 줄일 수도 있을거 같아요~!
Member
Author
There was a problem hiding this comment.
get(v, 0) 과 같이 기본값을 사용하는 것은 좋은 방법인 것 같습니다 ㅎㅎ
Contributor
|
마지막 개행문자가 없어 CI가 안 돌아가는데 이 부분만 수정해주시면 merge해드리겠습니다. |
Member
Author
|
@shinheekim 리뷰 감사합니다 ! 4, 5번은 답변을 참고하였습니다 ㅎㅎ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!