Merged
Conversation
added 2 commits
August 21, 2025 10:44
sonjh1217
approved these changes
Aug 24, 2025
| for (List<String> list : map.values()) { | ||
| groupList.add(list); | ||
| } | ||
| return groupList; |
Contributor
There was a problem hiding this comment.
groupList 변수 필요 없이 return new ArrayList<>(map.values()) 이런식으로도 가능하지는 않을까요?
그리고 groupList를 사용하는 곳 근처에 선언부가 있으면 좋을 것 같습니다. 선언하는 라인과 사용하는 라인 사이에 for loop이 있다보니 거기서 groupList를 사용하는 것처럼 보여서 다시 확인하게 되어서요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!