Merged
Conversation
hyogshin
approved these changes
Aug 23, 2025
| * | ||
| */ | ||
| function maxProfit(prices: number[]): number { | ||
| let min = prices[0]; |
There was a problem hiding this comment.
minPrice 처럼 의미가 분명한 변수명을 사용하면 좋을 것 같습니다.
|
|
||
| for (let i = 0; i < strs.length; i++) { | ||
| const key = strs[i].split("").sort().join(""); | ||
| map.set(key, [...(map.get(key) ?? []), strs[i]]); |
There was a problem hiding this comment.
map.set()은 매번 새 배열을 만들어야하니 꺼내서 push 하는 방식은 어떤가요?
| const length = Number(tempStr.slice(0, i)); | ||
| const currentStr = tempStr.slice(i + 1, i + 1 + length); | ||
| result.push(currentStr); | ||
| tempStr = tempStr.slice(length + i + 1); |
There was a problem hiding this comment.
slice로 원본을 잘라내면 불필요한 문자열 복사가 반복될 수 있으니 포인터를 만들어서 전진하는 방식도 고려해보면 좋을 것 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!