[재호] WEEK 02 Solutions #339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Aug 18, 2024
| * @return {boolean} | ||
| */ | ||
| var isAnagram = function(s, t) { | ||
| return s.split('').sort().join('') === t.split('').sort().join(''); |
There was a problem hiding this comment.
오..... 나누고 정렬하고 합치고 좋네요 배워갑니다!
DaleSeo
reviewed
Aug 21, 2024
construct-binary-tree-from-preorder-and-inorder-traversal/wogha95.js
Outdated
Show resolved
Hide resolved
요런 좋은 질문은 디스커션에 올려주시면 다른 분들도 생각할 기회가 생겨서 좋을 것 같습니다! |
DaleSeo
approved these changes
Aug 24, 2024
Comment on lines
+8
to
+25
| var countBits = function (n) { | ||
| const result = [0]; | ||
| let pointer = 0; | ||
| let lastPointer = 0; | ||
|
|
||
| for (let num = 1; num <= n; num++) { | ||
| result.push(result[pointer] + 1); | ||
|
|
||
| if (pointer === lastPointer) { | ||
| lastPointer = result.length - 1; | ||
| pointer = 0; | ||
| } else { | ||
| pointer += 1; | ||
| } | ||
| } | ||
|
|
||
| return result; | ||
| }; |
There was a problem hiding this comment.
이 투포인터 솔루션 신기한 것 같은데, 혹시 모임 때 소개해주실 수 있으실까요?
There was a problem hiding this comment.
달레님 알고리즘과 크게 다를 바 없다고 생각해서 조금 의아했는데 소개 이유를 들어보니 깨닫게 되었습니다!
그리고 갑작스럽게 발표준비하다보니 두서없이 설명드린것 같아서 걱정되었는데 부족한 부분 피드백 주셔서 감사합니다 :)
| @@ -0,0 +1,33 @@ | |||
| // TC: O(N) - leetcode analyze 기준 | |||
There was a problem hiding this comment.
복잡도 분석은 직접하시는 게 더 좋을 것 같습니다! 코딩 면접 때도 직접 하셔야하니까요 :)
There was a problem hiding this comment.
넵, leetcode analyze complexity에 의존하지 않고 직접 계산해보겠습니다!
| @@ -0,0 +1,33 @@ | |||
| // TC: O(N) - leetcode analyze 기준 | |||
| // SC: O(N) | |||
There was a problem hiding this comment.
평상시에 시간복잡도만 계산하고 공간복잡도는 대략적으로만 생각했는데 배열 복제의 메모리 사용도 고려해야하는지 몰랐습니다.. 😮
알고달레 블로그 확인해서 많이 도움 받았습니다 :) 감사합니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O(N)에다가 findIndex 순회O(N)이 중첩되어 있으니O(N^2)로 생각했는데 leetcode analyze 에서는 시간복잡도를O(N)으로 알려줍니다. 혹시 제가 시간복잡도 계산을 잘못한 것일까요?