Skip to content

[crispy] week 2 solution #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 25, 2024
Merged

[crispy] week 2 solution #359

merged 6 commits into from
Aug 25, 2024

Conversation

heozeop
Copy link
Contributor

@heozeop heozeop commented Aug 23, 2024 •
edited
Loading

@heozeop heozeop added the c++ label Aug 23, 2024
@heozeop heozeop self-assigned this Aug 23, 2024
@heozeop heozeop marked this pull request as ready for review August 24, 2024 01:45
@DaleSeo DaleSeo requested a review from GUMUNYEONG August 24, 2024 19:15
DaleSeo
DaleSeo approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5문제 다 푸시느라 수고 많으셨습니다. 시간 복잡도 분석이 의아한 부분이 있어서 코멘트 남겼습니다. 다른 멤버들이 코드 리뷰를 할 시간적 여유가 좀 있도록 PR을 조금만 더 빨리 올려주시면 좋을 것 같습니다.

counting-bits/heozeop.cpp Outdated
@@ -0,0 +1,31 @@
// Time Complexity: O(n^2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

count1() 함수가 로그 시간이 걸리지 않을까요? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러네요! 감사합니다!

@DaleSeo DaleSeo merged commit fac6215 into DaleStudy:main Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaleSeo DaleSeo DaleSeo approved these changes

@GUMUNYEONG GUMUNYEONG Awaiting requested review from GUMUNYEONG

Assignees

@heozeop heozeop

Labels
c++
Projects
No open projects
리트코드 스터디 2기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heozeop @DaleSeo