[재호] WEEK 08 Solutions #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HC-kang
approved these changes
Oct 5, 2024
| memory.set(val, new _Node(val)); | ||
| } | ||
|
|
||
| return memory.get(val); |
There was a problem hiding this comment.
여기서 모든 경우를 통합 처리하는것도 좋아보입니다.
하지만 62-64라인의 케이스인 경우에는 생성한 노드를 직접 리턴해 주는 것이 메모리 접근을 줄일 수 있지 않을까요?
There was a problem hiding this comment.
가독성 측면에서 (노드가 없으면 미리 만들고) 메모리에 있는 노드를 가져온다로 이해할 수 있도록 작성하였는데 오히려 불필요한 메모리 접근을 늘리는 것을 고려못했습니다!
리뷰 감사합니다!
| * | ||
| * SC: O(1) | ||
| * | ||
| * Bit: 2진수 a 와 b 중 비트 길이가 긴 것의 비트 길이 |
There was a problem hiding this comment.
이 표현은 log(max(a, b)) 정도로 볼 수 있을까요?
There was a problem hiding this comment.
앗 비트 길이를 어떻게 표현할 지 고민이었는데 log로 표현할 수 있었군요.!
아이디어 감사합니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.