Chore: integration workflow에 답안 파일 명을 "GitHub계정명".ext 형태로 강제하는 step 추가 #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
혼선의 여지가 없도록 안내문구에도 좀 더 정확히 표현해주면 어떨까요? |
DaleSeo
reviewed
Nov 29, 2024
.github/workflows/integration.yaml
Outdated
| env: | ||
| GH_TOKEN: ${{ github.token }} | ||
|
|
||
| - name: Check for 1. missing end line breaks and 2. control characters in filenames and 3. filename rules |
There was a problem hiding this comment.
이 스탭이 너무 길어진 것 같은데 혹시 3개로 나누어주실 수 있으실까요? 그럼, 답안 제출자가 어떤 단계에서 실패했는지 좀 더 쉽게 파악할 수 있을 것 같아요.
.github/workflows/integration.yaml
Outdated
Comment on lines
87
to
88
| # maintenance 라벨이 없는 경우에만 파일명 규칙 체크 | ||
| if [ "$has_maintenance" != "true" ]; then |
|
@DaleSeo 님께서 의견 주신내용 반영하여 PR 수정하였습니다!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
목적
동작 예시
올바른 파일명 사용시(HC-kang.js)
올바르지 않은 파일명 사용시(hckang.js)
예외사항
종종 아래와 같은 경우가 발생할 수 있습니다.
예시
이러한 경우
maintenance라벨을 사용하시면 해당 파일명 검증 스텝을 우회 할수 있습니다.기타