[choidabom] Week 1 #678
Merged
[choidabom] Week 1 #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Dec 13, 2024
Comment on lines
+13
to
+14
| const alphanumeric = getAlphanumeric(s) | ||
| return alphanumeric === alphanumeric.split("").reverse().join("") |
There was a problem hiding this comment.
검증 부분을 메서드화 하신 부분이 좋은것 같습니다 :)
HC-kang
approved these changes
Dec 14, 2024
There was a problem hiding this comment.
@choidabom 님, 깔끔한 풀이에 복잡도 분석까지 해주시니 정말 좋습니다!
다른 분들과도 의견 나누시면서, 코드를 좀 더 최적화 할 기회가 있었다면 더 좋았을텐데 아쉽네요!
다음 주차에는 좀 더 많은 상호 리뷰와 교류가 있었으면 좋겠습니다! 앞으로도 좋은 풀이 부탁드릴게요!
비록 아직 Solving 단계이시지만, 마감 시간이 다가온 관계로 리뷰 및 승인 드립니다!
| * @return {boolean} | ||
| */ | ||
| var containsDuplicate = function(nums) { | ||
| return new Set(nums).size !== nums.length |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.