[oyeong011] week2 #730
Merged
[oyeong011] week2 #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
안녕하세요 코치 Flynn입니다 |
obzva
reviewed
Dec 17, 2024
| // 즉 피보나찌 수열의 형태를 띈다 왜냐면 2칸을 뛰기 때문에 한칸전에 1을 더하고 두칸 전에 경우의 수에 2를 더해주면 되기때문 | ||
| // 즉 f(n) = f(n - 1) + f(n - 2) | ||
| // 만약 계단 방식이 3칸까지이면 즉 f(n) = f(n - 1) + f(n - 2) + f(n - 3) | ||
| // 시간복잡도는 n만큼 순회하여 O(n) |
There was a problem hiding this comment.
깔끔한 풀이에 피보나치 수열인 것까지 잘 캐치하신 것 같습니다 ㅎㅎ
누락된 공간 복잡도 분석 추가하시면 더 좋을 것 같고, 분석하시는 동시에 공간 복잡도를 최적화할 수 있을지 여부에 대해서 한 번 더 생각해보시면 좋을 것 같아요
obzva
reviewed
Dec 17, 2024
Comment on lines
+4
to
+5
| unordered_map<char, int> ss, tt; | ||
| if(s.length() != t.length())return false; |
There was a problem hiding this comment.
Suggested change
| unordered_map<char, int> ss, tt; | |
| if(s.length() != t.length())return false; | |
| if(s.length() != t.length())return false; | |
| unordered_map<char, int> ss, tt; |
s와 t의 길이가 다르면 unordered_map을 할당할 필요도 없으니까 5번 줄이 더 위에 있는게 나을 것 같아요
yeeZinu
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.