[Zioq] Week2 #745
Merged
[Zioq] Week2 #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgonD3V
approved these changes
Dec 21, 2024
Comment on lines
+13
to
+15
| let a = 0; | ||
| let b = 1; | ||
| let c = 0; |
There was a problem hiding this comment.
디버깅과 협업을 고려해서 각 변수의 의미를 표기하는 변수명 사용을 추천드립니다
lylaminju
approved these changes
Dec 22, 2024
Comment on lines
+23
to
+30
| for (let c of s) { | ||
| map[c] = (map[c] || 0) + 1; | ||
| } | ||
|
|
||
| for (let c of t) { | ||
| if (!map[c]) return false; | ||
| map[c]--; | ||
| } |
There was a problem hiding this comment.
변수 c가 불변이라면 let 대신에 const 사용하시는것도 좋을 것 같습니다. for (const c of s)
ref) https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.