Skip to content

[Wan] Week 4 #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2025
Merged

[Wan] Week 4 #830

merged 4 commits into from
Jan 5, 2025

Conversation

taewanseoul
Copy link
Contributor

@taewanseoul taewanseoul commented Jan 2, 2025 •
edited
Loading

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@taewanseoul taewanseoul requested a review from a team as a code owner January 2, 2025 15:27
@github-actions github-actions bot added the ts label Jan 2, 2025
@taewanseoul taewanseoul requested a review from Yjason-K January 2, 2025 15:29
HC-kang
HC-kang reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@HC-kang HC-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taewanseoul 님, 아직 풀이중이신 것으로 보여 우선 코멘트만 남기겠습니다!

merge-two-sorted-lists/taewanseoul.ts Outdated
*/

// O(n + m) time
// O(1) space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재귀 호출인 만큼 스택 공간이 필요할것으로 보여요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list1과 list2이 있으니 O(n + m)이 되겠군요...!

SamTheKorean
SamTheKorean approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 이번주도 고생하셨습니다!

@SamTheKorean SamTheKorean merged commit 2e88f27 into DaleStudy:main Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HC-kang HC-kang HC-kang left review comments

@SamTheKorean SamTheKorean SamTheKorean approved these changes

@Yjason-K Yjason-K Awaiting requested review from Yjason-K

Assignees

@taewanseoul taewanseoul

Labels
ts
Projects
No open projects
리트코드 스터디 3기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taewanseoul @HC-kang @SamTheKorean