[mallayon] Week 6 #899
Merged
[mallayon] Week 6 #899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HC-kang
approved these changes
Jan 17, 2025
| @@ -0,0 +1,33 @@ | |||
| /** | |||
| *@link https://leetcode.com/problems/container-with-most-water/description/ | |||
There was a problem hiding this comment.
감사합니다 👍 리뷰할 때 문제 보기 너무 좋아요!
valid-parentheses/mmyeon.ts
Outdated
| * | ||
| * 공간복잡도 : O(k) | ||
| * - pairs 객체 고정된 크기로 저장 O(1) | ||
| * - stack에 열린 괄호 개수만큼 담기니까 O(k) |
There was a problem hiding this comment.
전체 길이 n 중, 열린 괄호의 수를 k(<n)로 표현하신거죠?
There was a problem hiding this comment.
넵 맞습니다 !
k에 대한 설명이 빠졌네요! 주석 좀 더 자세하게 변경했습니다 ! 감사합니다 😄
spiral-matrix/mmyeon.ts
Outdated
| * - m x n 행렬의 모든 숫자 방문하니까 O(m x n) | ||
| * | ||
| * 공간복잡도 : O(n) | ||
| * - 숫자 길이만큼 배열에 담음 * |
There was a problem hiding this comment.
숫자 길이가 혹시 행렬의 모든 숫자 말씀이실까요?
그렇다면 시간복잡도와 같이 O(m x n)이 되지 않을까 싶어서요!
There was a problem hiding this comment.
네 맞습니다!
생각해보니 숫자 길이 n만큼만 반복하니까 O(n)으로 작성하는게 더 이해하기 좋을 것 같아요!
복잡도 모두 O(n)으로 수정했습니다~
꼼꼼히 봐주셔서 감사합니다 !!
| }; | ||
|
|
||
| while (top <= bottom && left <= right) { | ||
| moveRight(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.