[SunaDu] Week 6 #901
Merged
[SunaDu] Week 6 #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Jan 17, 2025
Comment on lines
+28
to
+32
| parentheses_map = { # SC: O(1) | ||
| "(": ")", | ||
| "{": "}", | ||
| "[": "]" | ||
| } |
There was a problem hiding this comment.
map 을 사용하지 않고 푸는 방법도 도전해도시면 재미있을것 같아요 :)
TonyKim9401
reviewed
Jan 17, 2025
Comment on lines
+46
to
+58
| def bisectLeft(self, list, target) -> int: | ||
| low = 0 | ||
| high = len(list) - 1 | ||
|
|
||
| while low <= high : | ||
| mid = int(low + (high - low) / 2) | ||
|
|
||
| if list[mid] < target: | ||
| low = mid + 1 | ||
| else: | ||
| high = mid - 1 | ||
|
|
||
| return low |
There was a problem hiding this comment.
bisectLeft 를 따로 함수로 빼셔서 각 함수들의 목적이 명확해 진 것 같아 넘 좋은것 같아요!
TonyKim9401
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.