[ganu] Week9 #983
Merged
[ganu] Week9 #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KwonNayeon
reviewed
Feb 3, 2025
KwonNayeon
approved these changes
Feb 7, 2025
Comment on lines
+15
to
+21
| if (nums.at(mid - 1) > nums.at(mid)) { | ||
| return nums[mid]; | ||
| } | ||
|
|
||
| if (nums.at(mid + 1) < nums.at(mid)) { | ||
| return nums[mid + 1]; | ||
| } |
There was a problem hiding this comment.
mid 값의 경계에 대한 조건을 없애면 코드를 더 단순화할 수 있을 것 같습니다!
Comment on lines
+16
to
+23
| // case 1 | ||
| cases.push(nums[i - 1]); | ||
|
|
||
| // case 2 | ||
| cases.push(nums[i - 1] * products[i - 1][0]); | ||
|
|
||
| // case 3 | ||
| cases.push(nums[i - 1] * products[i - 1][1]); |
There was a problem hiding this comment.
주석으로 케이스를 구분해주셔서 코드를 읽기 쉬웠습니다! 이번 주도 고생하셨습니다 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.