fix(datainsights): prevent TypeError when other_modes is None - #1416
Open
sentry[bot] wants to merge 1 commit into
Open
fix(datainsights): prevent TypeError when other_modes is None#1416sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1416 +/- ##
=======================================
Coverage 60.26% 60.26%
=======================================
Files 146 146
Lines 17222 17222
=======================================
Hits 10378 10378
Misses 6844 6844 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue DALGO-BACKEND-22D by adding
Noneguards for theother_modesfield in theparse_resultsmethods for both string and numeric type insights.Previously, if the database returned
Noneforother_modes(e.g., when no additional modes exist), aTypeError: 'NoneType' object is not iterablewould occur during list comprehension.The fix involves changing
result[0]["other_modes"]to(result[0]["other_modes"] or [])in:ddpui/core/datainsights/insights/string_type/queries.py(line 248)ddpui/core/datainsights/insights/numeric_type/queries.py(line 127)This ensures that the list comprehension always iterates over an iterable (an empty list if
other_modesisNone), preventing theTypeError.Fixes DALGO-BACKEND-22D