Update codebase for modern Ruby/Rails compatibility#56
Merged
Conversation
- Replace factory_girl_rails with factory_bot_rails - Replace FactoryGirl with FactoryBot in all specs - Replace .send(:alias_method) with .define_method for pagination - Replace validates_presence_of with validates :attr, presence: true - Replace old rspec 'should' syntax with 'expect' syntax - Update Rakefile generator flags for Rails 7 compatibility - Update app_template.rb for Rails 7 generator changes Refs #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update deprecated APIs and dependencies throughout the codebase to support Ruby 3.1+ and Rails 6.1-7.1.
Changes
factory_girl_railswas renamed tofactory_bot_railsin 2017. Updated require, constant references in all specs..shouldsyntax with modernexpect().tothroughout.ActionView::Base.send(:alias_method, ...)(removed in Ruby 3.x) with.define_method.validates_presence_of→validates :attr, presence: truein app template.rails newgenerator flags for Rails 7 (removed--skip-yarn,--skip-coffee,--skip-turbolinks,--skip-listen; added--skip-hotwire,--skip-jbuilder, etc.).Test Plan
send(:alias_method)Dependencies
Depends on #51 (CI matrix) being merged first for CI to pass.
Closes #52