Quote the Postgres identifiers used in DROP TRIGGER #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the DROP TRIGGER statements used for dropping Postgres triggers was generated by the
base.Trigger, which doesn't attempt any quoting. This behavior was inconsistent withpostgresql.Trigger.to_sql_create, which does add quotes in theCREATE TRIGGER ... ON ...statement. In practice, lack of quoting in the drop statement was causing issues for tables with special names, like"user".