Skip to content

Conversation

@daniel-lxs
Copy link
Contributor

🧪 Evaluation PR for Testing

This is an automated test PR created for evaluation purposes.


Related GitHub Issue

Closes: #4337

Description

This PR adds support for obtaining API keys from the environment. A checkbox is added to each configuration that allows inputting an API key -- when checked, a given environment variable (eg, OPENAI_API_KEY, etc) is consulted for the key and the user is not required to provide one in the configuration. Env Var key is predictable but not editable.

Test Procedure

I tested this using VS Code run configurations, where the expected environment variable could be provided or omitted.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).

A documentation update is advised, to describe environment variable usage to supply API keys.

Summary

Adds support for using environment variables for API keys across multiple providers, updates UI components to reflect this, and enhances testing and translation capabilities.

  • Behavior:
    • Adds support for API keys from environment variables for providers like anthropic, glama, openrouter, openai, gemini, mistral, deepseek, unbound, requesty, xai, groq, chutes, litellm.
    • Updates validateModelsAndKeysProvided() to check for environment variable usage for API keys.
  • UI Components:
    • Introduces ApiKey component to handle API key input and environment variable toggle.
    • Updates various provider components to use the new ApiKey component.
  • Testing:
    • Adds comprehensive tests for environment variable integration and the ApiKey component.

suprjinx added 30 commits May 27, 2025 16:44
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
OPENAI_API_KEY env var

Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
whole process.env into webview

Signed-off-by: Geoff Wilson <[email protected]>
of api key env var; use constants for env var keys.

Signed-off-by: Geoff Wilson <[email protected]>
errant keys in test file

Signed-off-by: Geoff Wilson <[email protected]>
suprjinx and others added 23 commits August 13, 2025 10:59
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
FIREWORKS: 'FIREWORKS_API_KEY',
HUGGING_FACE: 'HUGGINGFACE_API_KEY',
IO_INTELLIGENCE: 'IOINTELLIGENCE_API_KEY',
MOONSHOOT: 'MOONSHOT_API_KEY',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: MOONSHOOT should be MOONSHOT to match the environment variable name MOONSHOT_API_KEY. This typo will cause the constant to be named incorrectly throughout the codebase.

</div>
<ApiKey
apiKey={apiConfiguration?.moonshotApiKey || ""}
apiKeyEnvVar={API_KEYS.MOONSHOOT}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using typo MOONSHOOT instead of MOONSHOT. This references the misspelled constant from constants.ts line 25. Should be API_KEYS.MOONSHOT to correctly reference MOONSHOT_API_KEY.

return new QwenCodeHandler(options)
case "moonshot":
if (options.moonshotConfigUseEnvVars) {
options.moonshotApiKey = getEnvVar(API_KEYS.MOONSHOOT, options.moonshotApiKey)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using typo MOONSHOOT instead of MOONSHOT. This references the misspelled constant from constants.ts line 25. Should be API_KEYS.MOONSHOT to correctly reference MOONSHOT_API_KEY.

}: ApiKeyProps) => {
const envVarExists = (window as any).ENV_VAR_EXISTS || {}
const apiKeyEnvVarExists = !!envVarExists[apiKeyEnvVar]
const [useEnvVar, setUseEnvVar] = useState(configUseEnvVars && apiKeyEnvVarExists)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing useEffect to sync local state with prop changes. The useEnvVar state is initialized from configUseEnvVars but won't update if the prop changes later (e.g., when switching between provider profiles). Add:

useEffect(() => {
  setUseEnvVar(configUseEnvVars && apiKeyEnvVarExists)
}, [configUseEnvVars, apiKeyEnvVarExists])

@@ -0,0 +1,72 @@
import { useState, ReactNode } from "react"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing useEffect import. The suggested fix in the comment on line 34 requires importing useEffect from React.

const exists = !!process.env[envVar]
result[envVar] = exists
if (exists) {
console.log(`[ClineProvider] Found environment variable: ${envVar}`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use this.log() instead of console.log() for consistency with the rest of the ClineProvider class. The class has a dedicated logging method that outputs to both the output channel and console.

@daniel-lxs daniel-lxs closed this Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants