Skip to content

Conversation

@daniel-lxs
Copy link
Contributor

🧪 Evaluation PR for Testing

This is an automated test PR created for evaluation purposes.


Related GitHub Issue

Closes: #4337

Description

This PR adds support for obtaining API keys from the environment. A checkbox is added to each configuration that allows inputting an API key -- when checked, a given environment variable (eg, OPENAI_API_KEY, etc) is consulted for the key and the user is not required to provide one in the configuration. Env Var key is predictable but not editable.

Test Procedure

I tested this using VS Code run configurations, where the expected environment variable could be provided or omitted.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).

A documentation update is advised, to describe environment variable usage to supply API keys.

Summary

Adds support for using environment variables for API keys across multiple providers, updates UI components to reflect this, and enhances testing and translation capabilities.

  • Behavior:
    • Adds support for API keys from environment variables for providers like anthropic, glama, openrouter, openai, gemini, mistral, deepseek, unbound, requesty, xai, groq, chutes, litellm.
    • Updates validateModelsAndKeysProvided() to check for environment variable usage for API keys.
  • UI Components:
    • Introduces ApiKey component to handle API key input and environment variable toggle.
    • Updates various provider components to use the new ApiKey component.
  • Testing:
    • Adds comprehensive tests for environment variable integration and the ApiKey component.

suprjinx added 30 commits May 27, 2025 16:44
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
OPENAI_API_KEY env var

Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
whole process.env into webview

Signed-off-by: Geoff Wilson <[email protected]>
of api key env var; use constants for env var keys.

Signed-off-by: Geoff Wilson <[email protected]>
errant keys in test file

Signed-off-by: Geoff Wilson <[email protected]>
suprjinx and others added 25 commits August 13, 2025 10:10
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Signed-off-by: Geoff Wilson <[email protected]>
Copy link

@roo-code-dan roo-code-dan bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few issues that need to be addressed:

  1. Typo in constant name: MOONSHOOT should be MOONSHOT in packages/types/src/constants.ts
  2. Validation incompleteness: Missing environment variable checks in validation logic for newly supported providers (cerebras, sambanova, zai, fireworks, featherless, io-intelligence, vercel, doubao, moonshot, huggingface, deepinfra)

These issues will cause runtime failures when users try to use environment variables for API keys with the affected providers.

FIREWORKS: 'FIREWORKS_API_KEY',
HUGGING_FACE: 'HUGGINGFACE_API_KEY',
IO_INTELLIGENCE: 'IOINTELLIGENCE_API_KEY',
MOONSHOOT: 'MOONSHOT_API_KEY',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: MOONSHOOT should be MOONSHOT to match the environment variable name MOONSHOT_API_KEY used throughout the codebase.

return new QwenCodeHandler(options)
case "moonshot":
if (options.moonshotConfigUseEnvVars) {
options.moonshotApiKey = getEnvVar(API_KEYS.MOONSHOOT, options.moonshotApiKey)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constant reference uses API_KEYS.MOONSHOOT but the constant is misspelled in constants.ts (line 25). This will cause the environment variable lookup to fail at runtime since API_KEYS.MOONSHOOT resolves to 'MOONSHOT_API_KEY' but the constant name itself has a typo.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing validation updates for providers with new env var support. The PR adds *ConfigUseEnvVars flags for cerebras, sambanova, zai, fireworks, featherless, io-intelligence, vercel-ai-gateway, doubao, moonshot, huggingface, and deepinfra providers, but their validation cases (lines 62-65, 124-160) still require explicit API keys without checking the env var flags. These should follow the same pattern as anthropic (line 72), openrouter (line 42), etc. When the env var flag is enabled, validation should pass even without an explicit API key.

@daniel-lxs daniel-lxs closed this Oct 9, 2025
@daniel-lxs daniel-lxs deleted the eval-pr-review-feat-add-api-key-env-vars-1760051175702 branch October 9, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants