Draft
Conversation
When no config file exists, the config library builds from defaults alone, which fails with a confusing "missing field" error for version-specific settings like ohttp_relays. Detect whether any config file was actually loaded and, if not, append a hint telling the user where to create one or to use CLI arguments instead. Closes payjoin#855
Pull Request Test Coverage Report for Build 22572333999Details
💛 - Coveralls |
b8b3a67 to
c021627
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payjoin-clinow reports which paths were searched instead of showing a confusing "missing field" error~/.config/payjoin-cli/config.tomlor localconfig.toml) was actually loadedCloses payjoin#855
Test plan
nix fmt -- --cipassescargo clippy --all-targets --keep-going --all-features -- -D warningscleancodespellcleanDisclosure: co-authored by Claude