Draft
Conversation
bitcoind-async-client discards JSON-RPC error details from HTTP 500 response bodies, returning only "Obtained failure status(500): Internal Server Error". This leaves users without actionable information when e.g. a wallet is not loaded. Add an rpc_context helper that inspects the ClientError variant and appends diagnostic hints: - Status(500, _): suggest checking wallet loading and debug.log - Connection errors: suggest checking if bitcoind is running Apply the helper to every RPC call site in wallet.rs so all bitcoind errors surface useful context. The upstream library should also be fixed to parse JSON-RPC errors from non-2xx response bodies. Closes payjoin#1258
Pull Request Test Coverage Report for Build 22568490594Details
💛 - Coveralls |
DanGould
force-pushed
the
overnight/issue-1258
branch
from
87f5aad to
26b4c5a
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rpc_contexthelper that inspectsClientErrorvariants and appends actionable hintsdebug.logwallet.rsCloses payjoin#1258
Open questions
bitcoind-async-client— it callserror_for_status()before reading the response body, discarding JSON-RPC error messages. These hints are a stopgap. Upstream issue should be filed.Test plan
nix fmt -- --cipassescargo clippy --all-targets --keep-going --all-features -- -D warningscleancodespellcleanDisclosure: co-authored by Claude