Draft
Conversation
The ohttp-relay integration tests check for the NGINX_EXE environment variable and skip when it is not set. The CI workflow was adding nginx to PATH instead of setting NGINX_EXE, so the tests were silently skipped. Use GITHUB_ENV to set NGINX_EXE to the full binary path so the integration tests run in CI. Closes payjoin#1227
1fa5a2a to
6867464
Compare
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Pull Request Test Coverage Report for Build 22572331925Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set NGINX_EXE env var in CI workflow
Summary
The ohttp-relay integration tests use the
NGINX_EXEenvironment variable tolocate the nginx binary (introduced in payjoin#1237). However, the GitHub Actions CI
workflow was still using the old approach of adding nginx to
$GITHUB_PATHinstead of setting
NGINX_EXE. This meant the integration tests were silentlyskipped in CI since
NGINX_EXEwas not set.This PR updates both the Test and Coverage jobs in the CI workflow to set
NGINX_EXEvia$GITHUB_ENV, pointing to the full path of the nginx binarybuilt from the
nginx-with-streamnix package.Changes
.github/workflows/rust.yml: Replace$GITHUB_PATHwith$GITHUB_ENVtoset
NGINX_EXEto the full binary path in both Test and Coverage jobsTest plan
Closes payjoin#1227
Disclosure: co-authored by claude-code