⚡ Bolt: Optimize and fix hash join build-side collection #223
Conversation
This commit introduces two optimizations to the `collect_left_input` function in `HashJoinExec`: 1. **Empty Build-Side Handling:** Adds a check to detect when the build-side of the join is empty. In this case, it now returns early with an empty `RecordBatch` and `JoinHashMap`, preventing a panic that would occur from calling `concat_batches` on an empty vector. 2. **Single-Batch Fast Path:** Implements a fast path for when the build-side consists of a single `RecordBatch`. This avoids the overhead of calling `concat_batches`, which involves unnecessary memory allocation and data copying, leading to a significant performance improvement in such cases.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR optimizes the hash join build-side collection by adding a fast path for single-batch inputs and fixing a potential panic on empty inputs. These changes improve both performance and robustness.
PR created automatically by Jules for task 9831366548434749547 started by @Dandandan