Skip to content

Conversation

@google-labs-jules
Copy link

This pull request introduces a fast path for single-batch build sides in the HashJoinExec operator, avoiding an unnecessary concat_batches call and reducing memory allocation and CPU overhead. The change is verified by existing tests and is expected to improve performance in common join scenarios.


PR created automatically by Jules for task 10207775921161951588 started by @Dandandan

💡 **What**: This change introduces a fast path in the `HashJoinExec` operator for cases where the build-side input consists of a single `RecordBatch`.

🎯 **Why**: The existing implementation unconditionally uses `concat_batches` on the build-side input, even if there's only one batch. This operation involves unnecessary memory allocation and data copying, creating overhead.

📊 **Impact**: This optimization improves hash join performance by avoiding the `concat_batches` overhead for the common single-batch build-side scenario. This is particularly effective for joins with small build-side tables (e.g., dimension tables in a star schema). As noted in the code comment, this can reduce query time by ~15% for specific queries like TPC-H Q19.

🔬 **Measurement**: The performance improvement can be verified by running benchmarks that involve joins with small build-side inputs, such as the TPC-H benchmark suite. Existing unit and integration tests cover the correctness of this change.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant