Skip to content

Conversation

@google-labs-jules
Copy link

This patch adds a fast path to HashJoinExec for single-batch build-side inputs, avoiding an expensive concat_batches call to improve performance. The core logic in collect_left_input now checks for the single-batch case and processes it directly, falling back to the existing multi-batch logic otherwise. This reduces memory allocation and CPU overhead in a common join scenario.


PR created automatically by Jules for task 16672300022514928211 started by @Dandandan

This commit introduces a performance optimization to the `HashJoinExec` operator.

When the build side of a hash join consists of a single `RecordBatch`, this change bypasses the expensive `concat_batches` operation. This is a common scenario, and avoiding the extra memory allocation and CPU cycles for concatenation provides a measurable performance improvement.

The logic in `collect_left_input` now checks if the build side has only one batch. If so, it processes that batch directly. The existing, more general logic for handling multiple batches remains unchanged.
@google-labs-jules
Copy link
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant