Skip to content

[stable/redis-ha] Bump shellcheck in order to fix arm64 deployment#317

Merged
DandyDeveloper merged 2 commits intoDandyDeveloper:masterfrom
Skaronator:fix-arm64
Feb 17, 2025
Merged

[stable/redis-ha] Bump shellcheck in order to fix arm64 deployment#317
DandyDeveloper merged 2 commits intoDandyDeveloper:masterfrom
Skaronator:fix-arm64

Conversation

@Skaronator
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes

This fixes the issue that I'm unable to deploy the helm chart on arm64 nodes. This is due to v0.5.0 does not support arm64
https://hub.docker.com/r/koalaman/shellcheck/tags

Special notes for your reviewer:

After bumping just the shellcheck version I got this new error:


In /readonly-config/init.sh line 239:
    "Error: Could not resolve the announce ip for this pod."
    ^-- SC2288 (warning): This is interpreted as a command name ending with '.'. Double check syntax.

For more information:
  https://www.shellcheck.net/wiki/SC2288 -- This is interpreted as a command ...
stream closed EOF for argocd/argocd-redis-ha-configmap-test (check-init)

So I just removed that dot.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

Signed-off-by: Niklas Wagner <Skaro@Skaronator.com>
@DandyDeveloper DandyDeveloper merged commit 624db44 into DandyDeveloper:master Feb 17, 2025
2 checks passed
@Skaronator
Copy link
Contributor Author

Thanks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants