Skip to content

[stable/redis-ha] renamed redis-ha value "fullNameOverride" to "fullnameOverride" #326

Merged
DandyDeveloper merged 2 commits intoDandyDeveloper:masterfrom
maxgruber19:bugfix/fullnameoverride-not-effective
May 23, 2025
Merged

[stable/redis-ha] renamed redis-ha value "fullNameOverride" to "fullnameOverride" #326
DandyDeveloper merged 2 commits intoDandyDeveloper:masterfrom
maxgruber19:bugfix/fullnameoverride-not-effective

Conversation

@maxgruber19
Copy link
Contributor

What this PR does / why we need it:

fixes uneffective value "fullNameOverride" in redis-ha chart, which is spelled differently in helpers.tpl file

Which issue this PR fixes

Signed-off-by: Max Gruber <maxgruber19@gmail.com>
@maxgruber19 maxgruber19 changed the title [stable/mychartname] renamed redis-ha value "fullNameOverride" to "fullnameOverride" [stable/redis-ha] renamed redis-ha value "fullNameOverride" to "fullnameOverride" Mar 27, 2025
@ge1sterfahrer
Copy link

This issue has caused me more gray hairs than I'd like to admit and to make matters worse I am basically bald as well. Thanks @maxgruber19 for fixing it!

@DandyDeveloper
Copy link
Owner

@maxgruber19 @ge1sterfahrer Sorry about this :) The assignments aren't emailing me and I had no idea of the backlog in the repo. Thanks for the contribution. Approving and merging when it passes.

@DandyDeveloper
Copy link
Owner

I'm gonna have to trigger the builds again with a fake commit.

@DandyDeveloper DandyDeveloper merged commit 99fb393 into DandyDeveloper:master May 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chart/redis-ha][BUG] fullNameOverride not effective

3 participants