Skip to content

[stable/redis-ha]: fix: replace deprecated gitversion#348

Merged
DandyDeveloper merged 2 commits intoDandyDeveloper:masterfrom
kvanzuijlen:fix-deprecated-gitversion
Sep 12, 2025
Merged

[stable/redis-ha]: fix: replace deprecated gitversion#348
DandyDeveloper merged 2 commits intoDandyDeveloper:masterfrom
kvanzuijlen:fix-deprecated-gitversion

Conversation

@kvanzuijlen
Copy link
Contributor

What this PR does / why we need it:

Capabilities.KubeVersion.GitVersion was deprecated with the release of Helm v3.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Redo of #339 @DandyDeveloper

Sorry for the noise!

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@kvanzuijlen
Copy link
Contributor Author

Looks like I should use $.Capabilities.KubeVersion.Version after all. Weird how it is described in the documentation 😅.

@kvanzuijlen
Copy link
Contributor Author

@DandyDeveloper, you'll also have to update the branch protection rules

@DandyDeveloper DandyDeveloper merged commit 070639b into DandyDeveloper:master Sep 12, 2025
2 checks passed
@kvanzuijlen kvanzuijlen deleted the fix-deprecated-gitversion branch September 12, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants