Design protocol classes and update architecture for model comparison analysis#110
Draft
Design protocol classes and update architecture for model comparison analysis#110
Conversation
Co-authored-by: eh-main-bot <171766998+eh-main-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Design protocol classes and update architecture for model comparison analysis
Design protocol classes and update architecture for model comparison analysis
Jun 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
- Coverage 95.78% 92.88% -2.91%
==========================================
Files 19 21 +2
Lines 736 759 +23
==========================================
Hits 705 705
- Misses 31 54 +23 ☔ View full report in Codecov by Sentry. |
EH-MLS
reviewed
Jun 9, 2025
| A figure object containing the error distribution comparison. | ||
|
|
||
| """ | ||
| ... |
| A figure object containing the pairwise comparison visualization. | ||
|
|
||
| """ | ||
| ... |
| A figure object containing the performance summary visualization. | ||
|
|
||
| """ | ||
| ... |
Contributor
Author
There was a problem hiding this comment.
Removed test file as requested in 3b8c1a4
Contributor
Author
There was a problem hiding this comment.
Removed test file as requested in 3b8c1a4
Co-authored-by: eh-main-bot <171766998+eh-main-bot@users.noreply.github.com>
Collaborator
|
@copilot |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces model comparison analysis capabilities to tab-right by implementing two new protocol classes that follow the existing architectural patterns.
Changes Made
New Protocol Classes
1. Prediction Calculation Protocol (
model_comparison_protocols.py)PredictionCalculationP: Protocol for calculating pointwise errors between multiple prediction datasets and true labels__call__method accepts list of prediction Series and optional error function2. Plotting Protocol (
model_comparison_plot_protocols.py)ModelComparisonPlotP: Protocol for visualizing comparison results between multiple predictions and labelsArchitecture Integration
@runtime_checkableand@dataclassdecorators for consistencyTesting
Example Usage
The architecture now supports extensible model comparison analysis alongside existing segmentation and drift detection capabilities, providing a foundation for future analysis modules.
Fixes #109.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.