Remove UnivariateDriftCalculator from codebase#113
Draft
Conversation
Co-authored-by: eh-main-bot <171766998+eh-main-bot@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove UnivariateDriftCalculator from codebase
Remove UnivariateDriftCalculator from codebase
Jun 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 95.78% 95.76% -0.03%
==========================================
Files 19 19
Lines 736 708 -28
==========================================
- Hits 705 678 -27
+ Misses 31 30 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
UnivariateDriftCalculatorclass from the codebase as it was only used internally and provides overlapping functionality with the existingDriftCalculatorclass.Changes Made
UnivariateDriftCalculatorclass fromtab_right/drift/univariate.py(122 lines)detect_univariate_drift_df()to implement the logic directly instead of using the classUnivariateDriftCalculator(69 lines)dataclassandUnionimportsBenefits
detect_univariate_drift,detect_univariate_drift_df, etc.) work identicallyVerification
The
DriftCalculatorclass remains available for users who need object-oriented drift analysis, while the functional APIs provide a simpler interface for most use cases.Fixes #112.