Rename semi_float_type to semi to fix convergence test error

examples/structured_2d_dgsem/elixir_euler_convergence_implicit_sparse_jacobian.jl

@@ -78,23 +78,24 @@ coloring_vec = column_colors(coloring_result)
 ### sparsity-aware semidiscretization and ode ###
 
 # Semidiscretization for actual simulation
-semi_float_type = SemidiscretizationHyperbolic(mesh, equations,
-                                               initial_condition_convergence_test,
-                                               solver,
-                                               source_terms = source_terms_convergence_test)
+# Must be called 'semi' in order for the convergence test to run successfully
+semi = SemidiscretizationHyperbolic(mesh, equations,
+                                    initial_condition_convergence_test,
+                                    solver,
+                                    source_terms = source_terms_convergence_test)
 
 # Supply Jacobian prototype and coloring vector to the semidiscretization
-ode_jac_sparse = semidiscretize(semi_float_type, tspan,
+ode_jac_sparse = semidiscretize(semi, tspan,
                                 jac_prototype = jac_prototype,
                                 colorvec = coloring_vec)
-# using "dense" `ode = semidiscretize(semi_float_type, tspan)`
+# using "dense" `ode = semidiscretize(semi, tspan)`
 # is essentially infeasible, even single step takes ages!
 
 ###############################################################################
 ### callbacks & solve ###
 
 summary_callback = SummaryCallback()
-analysis_callback = AnalysisCallback(semi_float_type, interval = 50)
+analysis_callback = AnalysisCallback(semi, interval = 50)
 alive_callback = AliveCallback(alive_interval = 3)
 
 # Note: No `stepsize_callback` due to implicit solver

src/solvers/dgsem_p4est/dg_3d_parabolic.jl

@@ -200,7 +200,7 @@ function calc_gradient!(gradients, u_transformed, t,
                         # surface at -y
                         normal_direction = get_normal_direction(3,
                                                                 contravariant_vectors,
-                                                                l, m, 1, element)
+                                                                l, 1, m, element)
                         grad[v, l, 1, m, element] = (grad[v, l, 1, m, element] +
                                                      surface_flux_values[v, l, m, 3,
                                                                          element] *

test/test_parabolic_3d.jl

@@ -501,17 +501,17 @@ end
                                  "elixir_navierstokes_crm.jl"),
                         l2=[
                             2.2353998537135728e-10,
-                            6.438639847871375e-8,
-                            4.8159768090963756e-8,
-                            6.287534321002294e-8,
-                            7.596958320246443e-5
+                            6.438248564149087e-8,
+                            4.8158393932278836e-8,
+                            6.287149707414103e-8,
+                            7.591822518308327e-5
                         ],
                         linf=[
                             0.36753460935979454,
                             209.1460932734352,
-                            51.3036359192352,
-                            41.461135962058904,
-                            113004.3158457772
+                            51.303610073892436,
+                            41.45867326162659,
+                            113004.34493505303
                         ],
                         tspan=(0.0, 1e-10))
     # Ensure that we do not have excessive memory allocations

test/test_structured_2d.jl

@@ -255,7 +255,7 @@ end
                         ])
     # Ensure that we do not have excessive memory allocations
     # (e.g., from type instabilities)
-    @test_allocations(Trixi.rhs!, semi_float_type, sol, 1000)
+    @test_allocations(Trixi.rhs!, semi, sol, 1000)
 end
 
 @trixi_testset "elixir_eulermulti_convergence_ec.jl" begin