Skip to content

Fix uncaught exception when sorting columns in Graph Summary #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Olipro wants to merge 1 commit into
base: Main
Choose a base branch
from
Open

Fix uncaught exception when sorting columns in Graph Summary #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions Foreman/Forms/GraphSummaryForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,15 @@ private void ItemListView_ColumnSort(List<ListViewItem> unfilteredList, List<Lis
else
result = -((double)a.SubItems[column].Tag).CompareTo((double)b.SubItems[column].Tag);

if (result == 0)
result = ((DataObjectBase)a.Tag).LFriendlyName.CompareTo(((DataObjectBase)b.Tag).LFriendlyName);
if (result == 0)
result = ((DataObjectBase)a.Tag).Name.CompareTo(((DataObjectBase)b.Tag).Name);
if (result == 0 && a.Tag is DataObjectBase ado && b.Tag is DataObjectBase bdo) {
result = ado.LFriendlyName.CompareTo(bdo.LFriendlyName);
if (result == 0)
result = ado.Name.CompareTo(bdo.Name);
}

if (result == 0 && a.Tag is ItemQualityPair aqp && b.Tag is ItemQualityPair bqp && aqp.Quality != null)
result = aqp.Quality.Level.CompareTo(bqp.Quality.Level);

return result * reverseSortLamda;
});

Expand Down