Avoid data exporter crash with research-progress products #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factorio 2.0 added the "research-progress" product type for recipes, which is missing many of the fields which "item" and "fluid" has. It might be possible/useful to treat these as pseudo-items to allow building graphs to create them, but for now we should just ignore them to avoid the data exporter crashing. Fixes DanielKote#130
|
Would love if this commit could be merged! For the time being, I've just replaced the modified file in my local Foreman 2 files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factorio 2.0 added the "research-progress" product type for recipes, which is missing many of the fields which "item" and "fluid" has. It might be possible/useful to treat these as pseudo-items to allow building graphs to create them, but for now we should just ignore them to avoid the data exporter crashing.
Fixes #130